[Webkit-unassigned] [Bug 117941] code coverage report

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117941





--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org>  2013-06-25 15:30:09 PST ---
(From update of attachment 205424)
View in context: https://bugs.webkit.org/attachment.cgi?id=205424&action=review

> Tools/CodeCoverage/report.html:73
> +            // This is the contents of the images left of directories.

Why don't we use inline svg instead?

> Tools/CodeCoverage/report.html:353
> +                var dataFilename = '../../WebKitBuild/Coverage/' + window.location.search.substring(1) + '.json';

I'm not sure if it's a good idea to hard code the path like this.
Presumably, there are situations in which you want to copy files between different computers, etc...
and still want to be able to open it on the viewer.

> Tools/CodeCoverage/report.html:355
> +                xhr.open('GET', dataFilename, true);
> +                xhr.send();

This is not going to work unless the person explicitly disables local file restriction.
I would have preferred if we had used JSONP or generated a html file that contained this script & JSON.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.