[Webkit-unassigned] [Bug 117996] New: CSSRuleList.cpp and CSSGroupingRule.cpp should include <wtf/MemoryInstrumentationVector.h>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117996

           Summary: CSSRuleList.cpp and CSSGroupingRule.cpp should include
                    <wtf/MemoryInstrumentationVector.h>
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: asharif.tools at gmail.com


CSSRuleList.cpp and CSSGroupingRule.cpp use:

void WTF::reportMemoryUsage<WTF::RefPtr<WebCore::CSSRule>, 0ul>(WTF::Vector<WTF::RefPtr<WebCore::CSSRule>, 0ul> const*, WTF::MemoryObjectInfo*)

but do not include the template header that defines this function.

This gives a linker error when building with -fprofile-generate.

The fix is simple:


Index: Source/core/css/CSSGroupingRule.cpp
===================================================================
--- Source/core/css/CSSGroupingRule.cpp    (revision 152906)
+++ Source/core/css/CSSGroupingRule.cpp    (working copy)
@@ -32,6 +32,7 @@

 #include "core/css/CSSGroupingRule.h"

+#include <wtf/MemoryInstrumentationVector.h>
 #include "core/css/CSSParser.h"
 #include "core/css/CSSRuleList.h"
 #include "core/css/CSSStyleSheet.h"
Index: Source/core/css/CSSRuleList.cpp
===================================================================
--- Source/core/css/CSSRuleList.cpp    (revision 152906)
+++ Source/core/css/CSSRuleList.cpp    (working copy)
@@ -22,6 +22,7 @@
 #include "config.h"
 #include "core/css/CSSRuleList.h"

+#include <wtf/MemoryInstrumentationVector.h>
 #include "core/css/CSSRule.h"

 namespace WebCore {

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.