[Webkit-unassigned] [Bug 117039] [GStreamer] Support audio and video tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117039





--- Comment #35 from Brendan Long <b.long at cablelabs.com>  2013-06-24 10:32:07 PST ---
(In reply to comment #34)
> > Source/WebCore/ChangeLog:8
> > +        No new tests (OOPS!).
> 
> Please fix this line, remove OOPS, I suppose existing tests cover this change?

Actually, I need to write the tests, since audio/video tracks don't work in any other ports yet.

> > Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:2
> > + * Copyright (C) 2013 Apple Inc. All rights reserved.
> 
> You can mention yourself here or the company you work for :) Unless Apple hired you? About the header below, please make sure this is really the one you want to use.

Oh cool. I didn't realize we were allowed to mess with that. It looks like LGPLv2 is preferred in the GStreamer sections of WebKit?

> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:258
> > +        m_audioTracks[i]->disconnect();
> 
> Hum, isn't the Vector dtor supposed to do its job here? If the disconnect method is used only here it can be merged to the Track dtor.

The Vector holds RefPtr's, so the track destructor aren't necessarily called here (JavaScript could be holding a reference to a track for example).

> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:606
> > +        if (i < (gint)m_videoTracks.size()) {
> 
> I don't think a cast is needed here.

EFL won't build without the cast because it's a signed/unsigned comparison.

> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:621
> > +        track->disconnect();
> > +        m_videoTracks.removeLast();
> 
> Shouldn't removeLast() calls the track dtor?

Same problem as above, JavaScript may still be holding a reference to the track.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.