[Webkit-unassigned] [Bug 117868] New: It is not possible to bind both texture2D and textureCubeMap in one texture unit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117868

           Summary: It is not possible to bind both texture2D and
                    textureCubeMap in one texture unit
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebGL
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: p.szymanski3 at samsung.com


Created an attachment (id=205163)
 --> (https://bugs.webkit.org/attachment.cgi?id=205163&action=review)
TextureUnit code otpimization

WebGL specification points to OpenGL ES 2.0 specification (http://www.khronos.org/registry/gles/specs/2.0/es_full_spec_2.0.25.pdf)
and according to OpenGL ES 2.0 specification section 2.10:
"It is not allowed to have variables of different sampler types pointing to 
the same texture image unit within a program object. This situation can only 
be detected at the next rendering command issued, and an INVALID_OPERATION 
error will then be generated"

So now it is possible to bind both texture2D and textureCubeMap in the same texture unit.
Variables m_texture2DBinding and m_textureCubeMapBinding in WebGLRenderingContext::TextureUnitState are not necessary.
We can use just one variable m_textureBinding and provide less code for textureUnit operations and also slightly increase rendering performance

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.