[Webkit-unassigned] [Bug 117725] [Qt][WK2] memory leak in QQuickWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117725





--- Comment #3 from Sergio Villar Senin <svillar at igalia.com>  2013-06-21 00:55:02 PST ---
(From update of attachment 204881)
View in context: https://bugs.webkit.org/attachment.cgi?id=204881&action=review

Overall looks good, some Qt reviewer should take a look though. Some nits

> Source/WebKit2/ChangeLog:7
> +

You need to include a short description of the patch here.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:319
> +    if (experimental)

Why if? Isn't it always created?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1057
> +    if (schemeParent)

Same question here about the if.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1059
> +    if (m_test)

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.