[Webkit-unassigned] [Bug 117631] [GTK] Provide search functionality to MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117631





--- Comment #5 from Andres Gomez Garcia <agomez at igalia.com>  2013-06-20 06:45:02 PST ---
(In reply to comment #4)
> (From update of attachment 204686 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204686&action=review
> 
> r- mainly because of the coding style
> 

> Since you are defining the struct in the c file and nobody is going to inherit from this object, you can get rid of the private struct.

Totally removed.

> > Tools/MiniBrowser/gtk/BrowserSearchBar.c:208
> > +    g_weak_ref_init(&priv->weak, controller);
> 
> Why using this weak reaf instead of just getting a reference? I think you don't even need to keep a reference, since the find controller will always be available while the web view is alive
> 
> > Tools/MiniBrowser/gtk/BrowserWindow.c:477
> > +        browser_search_bar_request_close(BROWSER_SEARCH_BAR((window->searchBar)));
> 
> Extra parentheses there in BROWSER_SEARCH_BAR((window->searchBar)). Why don't you simply close the search bar here? this calls request_close, that emits close signal, that ends up calling searchBarCloseCallback that calls browser_search_bar_close(). It seems to me that we can just call browser_search_bar_close

Yeah, I think I was doing too much defensive programming ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.