[Webkit-unassigned] [Bug 117794] [EFL][WK2] Implement unit test callback: onWordGuesses

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117794





--- Comment #8 from Christophe Dumez <dchris at gmail.com>  2013-06-20 03:57:57 PST ---
(From update of attachment 205063)
View in context: https://bugs.webkit.org/attachment.cgi?id=205063&action=review

>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:294
>>> +        Ewk_Context_Menu_Item* item = static_cast<Ewk_Context_Menu_Item*>(eina_list_nth(contextMenuItems, i));
>> 
>> I think eina_list_nth may iterate through the list to find the nth item, in which case we would be better off using EINA_LIST_FOREACH() + i counter.
> 
> I don't want to iterate whole list, only the suggestions on the top.

Ok, it wasn't clear to me. Maybe a comment would help understand what you are actually testing then :) apparently, it is not self-explanatory :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.