[Webkit-unassigned] [Bug 117794] [EFL][WK2] Implement unit test callback: onWordGuesses

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117794





--- Comment #7 from Christophe Dumez <dchris at gmail.com>  2013-06-20 03:56:29 PST ---
(From update of attachment 205063)
View in context: https://bugs.webkit.org/attachment.cgi?id=205063&action=review

>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:290
>>> +    const Eina_List* contextMenuItems = ewk_context_menu_items_get(contextMenu);
>> 
>> Would be nice to add a check to make sure contextMenuItems and clientSuggestionsForWord are the same size.
> 
> contextMunuItems contains all items, not only suggestions. Suggestions are on the top. Would you like to check how many items are to *Ignore Spelling* item (*Ignore Spelling* is first item after suggestions)?

Ok, then an assertion that WTF_ARRAY_LENGTH(clientSuggestionsForWord) <= eina_list_count(contextMenuItem) ? just to make sure we abort before the loop in this error case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.