[Webkit-unassigned] [Bug 117281] Crash in V8 benchmarks set in ARM, softfp, EABI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117281





--- Comment #16 from Youngho Yoo <youngho33.yoo at lge.com>  2013-06-19 16:30:26 PST ---
(From update of attachment 203943)
View in context: https://bugs.webkit.org/attachment.cgi?id=203943&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        Crash fixex in V8 benchmark suite in ARM,softp,EABI environment.
> 
> Did you mean to say "Fixed crash in V8 benchmark suite for ARM, softfp, EABI environment"?

Yes, I will change that phrase.

>> Source/JavaScriptCore/dfg/DFGCCallHelpers.h:571
>> +    }
> 
> It seems these are not use in the ARM_HARDFP port.  I see no reason to add them.

But this is for EABI, ARM_HARDFP port. (relate with @1396, at 1494)
Is ARM_HARDFP port doesn't using EABI?
If or not, I will remove them.

>> Source/JavaScriptCore/dfg/DFGCCallHelpers.h:615
>> +    }
> 
> In the !ARM_HARDFP port, these replaces "setupArgumentsWithExecState(FPRReg arg1, GPRReg arg2)" and "setupArgumentsWithExecState(GPRReg arg1, GPRReg arg2, FPRReg arg3)".  Remove the now unused functions.

Similar reason like upper things.
But "setupArgumentsWithExecState(FPRReg arg1, GPRReg arg2)" and "setupArgumentsWithExecState(GPRReg arg1, GPRReg arg2, FPRReg arg3)" is for nonEABI, !ARM_HARDFP port. (relate with @1396, at 1494)
If there is no nonEABI and !ARM_HARDFP port, I will remove them.

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:-1041
>> -
> 
> Is there a reason that you move this function below?

Yes.
first of all, "#define EABI_32BIT_DUMMY_ARG      TrustedImm32(0)"(@1303), only exists in "#else // USE(JSVALUE32_64)"(@1298).
So, because of that, I need to seperate "#if USE(JSVALUE64)"(@1089) and "#else // USE(JSVALUE32_64)"(@1298).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.