[Webkit-unassigned] [Bug 117497] Improve algorithm of removing user and pass, by seperating new function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117497


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204876|review?                     |review+
               Flag|                            |




--- Comment #7 from Darin Adler <darin at apple.com>  2013-06-18 18:22:30 PST ---
(From update of attachment 204876)
View in context: https://bugs.webkit.org/attachment.cgi?id=204876&action=review

I still don’t see any data about whether this is a measurable speedup or not.

> Source/WebCore/platform/KURL.cpp:819
> +    if (m_userStart != end) {
> +        parse(m_string.left(m_userStart) + m_string.substring(end));
> +        return true;
> +    }
> +    return false;

This would read better as an early return:

    if (m_userStart == end)
        return false;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.