[Webkit-unassigned] [Bug 117730] [ATK] Added support for aria-required attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117730





--- Comment #5 from chris fleizach <cfleizach at apple.com>  2013-06-18 09:04:53 PST ---
(From update of attachment 204912)
View in context: https://bugs.webkit.org/attachment.cgi?id=204912&action=review

Why does these tests need to be efl/gtk only? they look like they could pass on the Mac without issue as well.
There are also a few accessibility "required" tests that already exist. Do those provide the same coverage? Can they be unskilled by GTK?

> LayoutTests/platform/efl/accessibility/aria-required.html:25
> +          var succeeded = obj.isRequired;

Before outputting these results it would be nice to explain what is being tested like
debug("Verify that isRequired is true when aria-required=true");
So that a failing case is easy to diagnose

> LayoutTests/platform/efl/accessibility/aria-required.html:26
> +          shouldBe("succeeded", "true");

for these, it would be preferable to write
shouldBeTrue("obj.isRequired")

which will give more context if they fail

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.