[Webkit-unassigned] [Bug 117728] [EFL][WK2] Implement unit test callback: onSettingChange

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117728





--- Comment #11 from Krzysztof Wolanski <k.wolanski at samsung.com>  2013-06-18 08:22:12 PST ---
(From update of attachment 204914)
View in context: https://bugs.webkit.org/attachment.cgi?id=204914&action=review

>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:279
>> +    EINA_LIST_FOREACH(contextMenuItems, listIterator, itemData) {
> 
> Still looks like a lot of duplication with selectContextMenuOption(). How about renaming the utility function to findContextMenuItem() and call it twice?

Sorry for inconvenience, method selectContextMenuOption() will be helpful in next test cases, when option will be selected directly from context menu.

>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:288
>> +    ADD_FAILURE();
> 
> ADD_FAILURE(); is non fatal. Why cannot we use FAIL() in a function returning a boolean?

When I use FAIL() instead of ADD_FAILURE(), it returns en error at compile time:
test_ewk2_text_checker.cpp:288:5: error: void value not ignored as it ought to be

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.