[Webkit-unassigned] [Bug 117695] [WinCairo] Webfont rendering is broken.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117695





--- Comment #5 from peavo at outlook.com  2013-06-18 07:30:10 PST ---
(In reply to comment #2)

Thanks for reviewing, Brent!

> > Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp:82
> >  FontCustomPlatformData* createFontCustomPlatformData(SharedBuffer* buffer)
> 
> Should this be declared static now? It's not used outside this module, is it?

Yes, it's used by WebCore\loader\cache\CachedFont.cpp.

> > Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.h:-49
> > -    cairo_font_face_t* m_fontFace;
> 
> Is there no benefit to holding the cairo_font_fact_t*?  Is it needed anywhere else?

I don't think it's currently needed elsewhere (no compile errors). The FontCustomPlatformData object is only used to create a FontPlatformData object via the fontPlatformData() method, and the cairo_font_face_t pointer is only used to create a cairo_scaled_font_t pointer in the FontPlatformData constructor, so I believe it can be a temporary variable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.