[Webkit-unassigned] [Bug 117728] [EFL][WK2] Implement unit test callback: onSettingChange

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117728





--- Comment #5 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2013-06-18 05:57:19 PST ---
(From update of attachment 204895)
View in context: https://bugs.webkit.org/attachment.cgi?id=204895&action=review

>From spellchecking side it looks sane. Added some comments.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:240
> +            break;

It seems that you didn't apply Chris' comment properly. I am in a favor of return here so we could call ADD_FAILURE outside the loop. Moreover, would be nice to add additional indent here.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:290
> +            break;

Ditto.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:396
> +    ASSERT_TRUE(waitUntilTrue(callbacksExecutionStats.settingChange));

Please make additional line here as this is rather part of cleaning.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:416
> +    ASSERT_FALSE(waitUntilTrue(callbacksExecutionStats.settingChange, defaultTimeoutInSeconds));

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.