[Webkit-unassigned] [Bug 117137] [GTK] Remote inspector server should send an error page if resources not found

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117137





--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2013-06-17 06:19:23 PST ---
(From update of attachment 203568)
View in context: https://bugs.webkit.org/attachment.cgi?id=203568&action=review

Have you considered doing a g_warning on all of the return false cases? That should make it much easier to debug things, generally.

>> Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:59
>> +        if (error->code == G_IO_ERROR_NOT_FOUND) {
> 
> I wonder if I should send some basic error page for other errors - unknown error during retrieving inspector resources - or something like that.

I think that makes sense, yeah. On second thought, this is likely to hit technical people, so maybe just don't do the error->code check: show it and error->message as well, should make it easier for those people to debug it.

> Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:63
> +            builder.appendLiteral(", make sure that you have set WEBKIT_INSPECTOR_SERVER_PATH in your environment to point to webinspector folder.</body></html>");

How about "make sure you ran make install or have set WEBKIT_…"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.