[Webkit-unassigned] [Bug 90272] <video> element delays document load event for ~ 3 seconds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90272


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204669|review?                     |review+
               Flag|                            |




--- Comment #8 from Eric Carlson <eric.carlson at apple.com>  2013-06-14 07:30:50 PST ---
(From update of attachment 204669)
View in context: https://bugs.webkit.org/attachment.cgi?id=204669&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::HTMLMediaElement::prepareForLoad):

Nit: I think it is useful to have per-method comments so it is easier to understand what changed when reading the ChangeLog later.

> LayoutTests/media/media-preload-no-delay-loadevent.html:8
> +        testRunner.waitUntilDone();

Nit: double indent

> LayoutTests/media/media-preload-no-delay-loadevent.html:37
> +    var source = document.getElementById('source');
> +    source.src = findMediaFile("video", "content/test.mp4");

Nit: there is no need to use a <source> element when only one media url is used.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.