[Webkit-unassigned] [Bug 116042] [GStreamer] [texmap] upload a video buffer into the video texture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116042





--- Comment #33 from Sebastian Dröge <slomo at circular-chaos.org>  2013-06-14 02:08:35 PST ---
(In reply to comment #31)
> Thanks for the review Sebastian :) Usually though only "official reviewers" are allowed to r+/r-. Anyway, props for the valuable comments on the patch.

Ah, I assumed that it would be ok because I apparently had permissions for that :) Sorry
I hope that doesn't mean that random people can also cq+? ;)

(In reply to comment #32)
> (From update of attachment 204424 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204424&action=review
> 
> >> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:44
> >> +#define GST_SURFACE_CAPS "video/x-surface, opengl=true; "
> > 
> > Erm... no. There should not be any video/x-surface caps in 1.0 anywhere. Maybe you mean "video/x-raw(meta:GstVideoGLTextureMapper)" here?
> 
> Currently only gstreamer-vaapi can offer the GstVideoGLTextureMapper meta, but it won't offer x-raw buffers, only the custom caps video/x-surface:
> https://bugzilla.gnome.org/show_bug.cgi?id=687183#c22
> 
> I can add both, otherwise this patch will be useless for a while.

Can you add video/x-raw to gstreamer-vaapi instead please? We really don't want caps such as video/x-surface anymore in 1.0 and I don't think it's a good idea to lead by bad example here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.