[Webkit-unassigned] [Bug 117625] [EFL][WK2] Fix crash issue on ewk_context_favicon_database_directory_set()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117625





--- Comment #4 from Changhyup Jwa <ch.jwa at samsung.com>  2013-06-13 22:50:18 PST ---
(In reply to comment #2)
> (From update of attachment 204674 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204674&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKContext.cpp:287
> > +bool WKContextSetIconDatabasePath(WKContextRef contextRef, WKStringRef iconDatabasePath)
> 
> You should avoid changing C API if possible. Most C API setters don't return bool so this seems a bit inconsistent.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:-161
> > -    if (iconDatabase->isOpen())
> 
> I remember we added this check for a specific reason. iirc the icon database path can only be set once. When the path is set the first time, the icon database gets enabled / opened. Therefore, checking for isOpen() was used to make sure we set the icon database path only once (and avoid assertion hit in debug mode).

Oh, attached another patch at the same time.

I'll check what you commented. Thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.