[Webkit-unassigned] [Bug 117617] CSSParser::parseImageSet() doesn't need a parameter.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 13 19:27:52 PDT 2013


--- Comment #3 from Jaehun Lim <ljaehun.lim at samsung.com>  2013-06-13 19:26:28 PST ---
(From update of attachment 204653)
View in context: https://bugs.webkit.org/attachment.cgi?id=204653&action=review

Thanks for your review.

>> Source/WebCore/css/CSSParser.cpp:8028
>> +    ASSERT(value->unit == CSSParserValue::Function && value->function);
> We never use && in an ASSERT. Instead use two separate assertions so you can see which failed.
>     ASSERT(value->unit == CSSParserValue::Function);
>     ASSERT(value->function);
> But also, I don’t think that ASSERT(value->function) is all that useful. We’ll see the null dereference right after this, it won’t be hard to debug. And there’s no reason to expect a null here.

I'll remove 'value->function'

>> Source/WebCore/css/CSSParser.cpp:8042
>> +        imageSet->append(image.release());
> Why use a local variable at all? I think this is better in a single line.

I'll make it one line.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list