[Webkit-unassigned] [Bug 117617] CSSParser::parseImageSet() doesn't need a parameter.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117617


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204653|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2013-06-13 17:56:34 PST ---
(From update of attachment 204653)
View in context: https://bugs.webkit.org/attachment.cgi?id=204653&action=review

> Source/WebCore/css/CSSParser.cpp:8028
> +    ASSERT(value->unit == CSSParserValue::Function && value->function);

We never use && in an ASSERT. Instead use two separate assertions so you can see which failed.

    ASSERT(value->unit == CSSParserValue::Function);
    ASSERT(value->function);

But also, I don’t think that ASSERT(value->function) is all that useful. We’ll see the null dereference right after this, it won’t be hard to debug. And there’s no reason to expect a null here.

> Source/WebCore/css/CSSParser.cpp:8042
>          RefPtr<CSSImageValue> image = CSSImageValue::create(completeURL(arg->string));
> -        imageSet->append(image);
> +        imageSet->append(image.release());

Why use a local variable at all? I think this is better in a single line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.