[Webkit-unassigned] [Bug 100379] [Win] WebView didReceiveIcon delegate call doesn't have the icon in it

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100379


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #171249|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #8 from Brent Fulgham <bfulgham at webkit.org>  2013-06-13 10:16:31 PST ---
(From update of attachment 171249)
View in context: https://bugs.webkit.org/attachment.cgi?id=171249&action=review

Looks good.  I think it would be simpler to create one IntSize and use it in both API calls that need it.  Can you make that small change and I'll r+ this?

> Source/WebKit/win/WebView.cpp:2842
> +        sz.cy = 16;

Why not just create the IntSize directly, then use it later?

> Source/WebKit/win/WebView.cpp:2844
> +        BitmapInfo bmInfo = BitmapInfo::create(IntSize(sz));

Use the IntSize here...

> Source/WebKit/win/WebView.cpp:2848
> +        Image* icon = iconDatabase().synchronousIconForPageURL(str, IntSize(sz));

... and here!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.