[Webkit-unassigned] [Bug 117342] [curl] Merge http response header values

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 13 09:42:41 PDT 2013


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #204580|review?                     |review-
               Flag|                            |

--- Comment #10 from Brent Fulgham <bfulgham at webkit.org>  2013-06-13 09:41:17 PST ---
(From update of attachment 204580)
View in context: https://bugs.webkit.org/attachment.cgi?id=204580&action=review

Looks great!  I had a couple of minor suggestions.  If you can clarify that comment I will be happy to approve the patch.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:241
> +    static const char *appendableHeaders[] = {

This should be "static const char*"  The fact that this is a "const char pointer" is part of the type.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:270
> +    // Custom headers usually starts with 'X-', allow them.

"starts" should be "start" (syntax).

If they usually start with "X-", why do we test with "x-" (case insensitive)?  Do they usually start with either "X-" or "x-" and we are handling this case and exiting early?

Maybe the comments should be "Custom headers start with 'X-', and need no further checking.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list