[Webkit-unassigned] [Bug 117223] [CSS Blending] Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117223


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204554|review?                     |review-
               Flag|                            |




--- Comment #4 from Dirk Schulze <krit at webkit.org>  2013-06-13 07:50:22 PST ---
(From update of attachment 204554)
View in context: https://bugs.webkit.org/attachment.cgi?id=204554&action=review

> LayoutTests/css3/compositing/background-blend-mode-image-color-dynamic.html:29
> +        for (var i = 0; i < blendModes.length; ++i) {
> +            var elem = document.createElement('div');
> +            document.body.appendChild(elem);
> +        }

Are you sure that this test really does the job of testing repaint? I would use the repaint logic from DRT and have a pixel result of the changed area. Then you don't need to test all blend modes, but just if the drawn content changed at all. We already have test to verify that the property value changed. You should find real repaint tests all over the place.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.