[Webkit-unassigned] [Bug 117533] [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117533





--- Comment #2 from Sergio Villar Senin <svillar at igalia.com>  2013-06-12 04:58:18 PST ---
(From update of attachment 204425)
View in context: https://bugs.webkit.org/attachment.cgi?id=204425&action=review

Overall LGTM

> Tools/ChangeLog:11
> +        itself on link left clicking.

The patch description normally goes just after the Reviewed by paragraph. These lines are normally used to comment about specific implementation stuff in some functions

> Tools/MiniBrowser/gtk/BrowserWindow.c:371
> +            mimeType = webkit_uri_response_get_mime_type(response);

It's normally preferred to initialize the values in the declarations so:

WebKitResponsePolicyDecision *responseDecision = WEBKIT_RESPONSE_POLICY_DECISION(decision);
WebKitURIResponse *response = webkit_response_policy_decision_get_response(responseDecision);

and the like

> Tools/MiniBrowser/gtk/BrowserWindow.c:379
> +            if (g_strcmp0 (webkit_web_resource_get_uri(mainResource), requestURI))

remove the blank after g_strcmp0

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.