[Webkit-unassigned] [Bug 116873] [Qt][WK2] Make the work queue take the ownership of the socket descriptor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116873


Lamarque V. Souza <Lamarque.Souza at basyskom.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204370|                            |review?, commit-queue?
               Flag|                            |




--- Comment #1 from Lamarque V. Souza <Lamarque.Souza at basyskom.com>  2013-06-11 16:46:36 PST ---
Created an attachment (id=204370)
 --> (https://bugs.webkit.org/attachment.cgi?id=204370&action=review)
Patch

Proposed patch. By what I can see only Connection::platformInitialize() closes the socket descriptor in the Qt port. This patch moves the loop closing the socket descriptor to SocketNotifier's destructor. SocketNotifier is a new class that inherits from QSocketNotifier. SocketNotifier is destroyed a few lines below the loop in Connection::platformInvalidate(), so this change should keep things working the same as before. I tested this change with the 'Test case' patch in https://bugs.webkit.org/show_bug.cgi?id=115880 and it passes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.