[Webkit-unassigned] [Bug 116042] [GStreamer] [texmap] upload a video buffer into the video texture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116042





--- Comment #26 from Víctor M. Jáquez L. <vjaquez at igalia.com>  2013-06-11 02:24:51 PST ---
(From update of attachment 204061)
View in context: https://bugs.webkit.org/attachment.cgi?id=204061&action=review

>>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:356
>>> +        ret = gst_video_gl_texture_upload_meta_upload(meta, ids);
>> 
>> What's happening behind the scenes here? Is it just using the current OpenGL context? If not I wonder about the cost of context switching.
>> 
>> In WebKit we do early returns, so you should write:
>> 
>> if (GstVideoGLTextureUploadMeta* meta = gst_buffer_get_video_gl_texture_upload_meta(buffer)) {
>>     if (gst_video_gl_texture_upload_meta_upload(meta, ids)) {
>>         client()->setPlatformLayerNeedsDisplay();
>>         return;
>>     }
>> }
>> 
>> The nice benefit being you don't have to touch the code below it.
> 
> What's happening behind the scenes here? Is it just using the current OpenGL context? If not I wonder about the cost of context switching.
> 
> In WebKit we do early returns, so you should write:
> 
> if (GstVideoGLTextureUploadMeta* meta = gst_buffer_get_video_gl_texture_upload_meta(buffer)) {
>     if (gst_video_gl_texture_upload_meta_upload(meta, ids)) {
>         client()->setPlatformLayerNeedsDisplay();
>         return;
>     }
> }
> 
> The nice benefit being you don't have to touch the code below it.

Martin, Yes, it is using the current OpenGL context. Behind the scenes were a calling a this function vaCopySurfaceGLX: http://www.sourcecodebrowser.com/libva/1.0.4/va__glx_8h.html#ab3e822b68bbb2da0aadc25911ad42aae

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.