[Webkit-unassigned] [Bug 117492] New: Get rid of extraneous accessibility tree traversal code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 10 23:00:31 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117492

           Summary: Get rid of extraneous accessibility tree traversal
                    code
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Accessibility
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: darin at apple.com, cfleizach at apple.com,
                    mrobinson at webkit.org


Consider merging https://chromium.googlesource.com/chromium/blink/+/dc0367e0c01205a6c9289e35260ca46ae4f86566

We never used AccessibilityRenderObject::previousSibling, and
I've been scared for a long time someone would accidentally
use it and we'd discover it's full of bugs, since it had no
test coverage. (Several bugs have been caught in nextSibling over
the years.) Time for it to die.

We also don't need AccessibilityObject::lastChild, though
the implementation was trivial.

The public interface needs even less - we can get rid of
firstChild, lastChild, nextSibling, and previousSibling,
because childAt is the only one called.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list