[Webkit-unassigned] [Bug 117479] New: Remove virtual from functions that are never overridden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117479

           Summary: Remove virtual from functions that are never
                    overridden
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Accessibility
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: darin at apple.com, andersca at apple.com, koivisto at iki.fi,
                    cfleizach at apple.com, akling at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/27ae848f12fb48ae823605c434b4a3ce96ac2c53

I checked these by writing a quick Python script; none of these functions
are found in any other header files in this directory.

I was surprised how much this cuts down on code size. I'm going to
aggressively get rid of virtual functions when they're not useful.
The main reason this helps so much is because there are so many subclasses of AccessibilityObject.

I wonder if we have LLVM tool that finds unnecessary virtual for us?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.