[Webkit-unassigned] [Bug 117464] New: Have to invalidate the mute button when changing the volume
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 10 18:41:06 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=117464
Summary: Have to invalidate the mute button when changing the
volume
Product: WebKit
Version: 528+ (Nightly build)
Platform: Unspecified
OS/Version: Unspecified
Status: NEW
Keywords: BlinkMergeCandidate
Severity: Normal
Priority: P2
Component: Media Elements
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: rniwa at webkit.org
Consider merging https://chromium.googlesource.com/chromium/blink/+/c4c685c82908449526fd8c251cc551e729ebed08
This is because the painting code in
RenderMediaControlsChromium.cpp:paintMediaMuteButton depends on the
volume, and that code gets called via RenderTheme, so nothing else can
invalidate the button.
diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp
index c418b69..37a0418 100644
--- a/Source/core/html/shadow/MediaControls.cpp
+++ b/Source/core/html/shadow/MediaControls.cpp
@@ -225,6 +225,8 @@
{
if (m_volumeSlider)
m_volumeSlider->setVolume(m_mediaController->volume());
+ if (m_panelMuteButton && m_panelMuteButton->renderer())
+ m_panelMuteButton->renderer()->repaint();
}
void MediaControls::changedClosedCaptionsVisibility()
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list