[Webkit-unassigned] [Bug 117436] New: Correctly calculate auto margins for column flows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117436

           Summary: Correctly calculate auto margins for column flows
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: hyatt at apple.com, dino at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/4727602ff32037dede84f2acd9534d6256f3e001

In RenderBox::computeInlineDirectionMargins, we have to pretend that
auto margins are zero so that the line cross size gets calculated
correctly (compare http://dev.w3.org/csswg/css-flexbox/#auto-margins)

That fix exposed a bug in RenderFlexibleBox::updateAutoMarginsInCrossAxis,
which needs to take LTR/RTL-ness into account -- it needs to adjust the
position iff margin-before is auto, which can be margin-right.

This CL also adds a few comments in an attempt to clarify the code a little.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.