[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117220


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204168|review?                     |review+
               Flag|                            |




--- Comment #67 from Dean Jackson <dino at apple.com>  2013-06-10 15:13:31 PST ---
(From update of attachment 204168)
View in context: https://bugs.webkit.org/attachment.cgi?id=204168&action=review

> Source/WebCore/page/ContextMenuController.cpp:1366
> +        case ContextMenuItemTagToggleVideoFullscreen:
> +#if SUPPORTS_TOGGLE_VIDEO_FULLSCREEN
> +                if (!m_hitTestResult.mediaIsInFullscreen())
> +                    item.setTitle(contextMenuItemTagEnterVideoFullscreen());
> +                else 
> +                    item.setTitle(contextMenuItemTagExitVideoFullscreen());
> +                break;
> +#endif

Nit: indent here is one level too many.

Also, I suggest rewriting this as item.setTitle(m_hitTestResult.mediaIsInFullscreen() ? contextMen...)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.