[Webkit-unassigned] [Bug 117392] New: webkit2: plugins on page reload breaks on resident modules

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117392

           Summary: webkit2: plugins on page reload breaks on resident
                    modules
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Major
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: prahal at yahoo.com


Sum up  of the gnome-shell browser plugin bug report : https://bugzilla.gnome.org/show_bug.cgi?id=691686
"I applied this patch to webkit and now the issue is gone:
--------------------------------------------------------------------
diff -uNr webkitgtk-1.11.92/Source/WebKit2/PluginProcess/PluginProcess.cpp
webkitgtk-1.11.92_prahal/Source/WebKit2/PluginProcess/PluginProcess.cpp
--- webkitgtk-1.11.92/Source/WebKit2/PluginProcess/PluginProcess.cpp   
2013-02-12 17:22:50.000000000 +0100
+++ webkitgtk-1.11.92_prahal/Source/WebKit2/PluginProcess/PluginProcess.cpp    
2013-05-29 19:09:23.607126634 +0200
@@ -115,6 +115,9 @@
     }        

     enableTermination();
+
+    if (shared().shouldTerminate())
+        shared().terminate();
 }

 NetscapePluginModule* PluginProcess::netscapePluginModule()
--------------------------------------------------------------------

that is webkit2 does terminate the plugin process only after a timeout (and
start terminating it when the page close). Also the timeout is 600. 
As jasper pointer out on #gnome-shell irc:
"the plugin process should restart when the page loads" .
webkit2 does only if the time between the close and open of the new page is
more than 600 seconds. Which on reload never happens. So I made this patch that
trigger plain terminate on PluginProcess::removeWebProcessConnection and all is
fine)."

This might affect other plugins.
The crash triggers not only on page reload but also if one go to another page and back to a page that uses the gnome-shell browser plugins.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.