[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 9 19:46:51 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117220





--- Comment #65 from Ruth Fong <ruthiecftg at gmail.com>  2013-06-09 19:45:24 PST ---
(From update of attachment 204081)
View in context: https://bugs.webkit.org/attachment.cgi?id=204081&action=review

>> Source/WebCore/page/ContextMenuController.cpp:854
>>              appendItem(EnterVideoFullscreen, m_contextMenu.get());
> 
> Here is the place where we want only one or the other. I think this is part that needs to be in an #if.

Yeah, we should probably put an #if here (though each port should take the populated list of context menu items and make final edits beforehand).

> Source/WebCore/page/ContextMenuController.cpp:1352
> +#if PLATFORM(MAC)

Here's another place we need the #if (since contextMenuItemTagExitVideoFullscreen() is not supported on all ports)

Since the two places we need #if statements is in ContextMenuController; perhaps I can define a SUPPORTS_TOGGLE_VIDEO_FULLSCREEN feature in the header or create a static helper function that checks whether the given port supports "toggle".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list