[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 8 18:44:02 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=117220
--- Comment #63 from Darin Adler <darin at apple.com> 2013-06-08 18:42:34 PST ---
(From update of attachment 204078)
View in context: https://bugs.webkit.org/attachment.cgi?id=204078&action=review
> Source/WebCore/page/ContextMenuController.cpp:854
> + appendItem(ToggleVideoFullscreen, m_contextMenu.get());
> appendItem(EnterVideoFullscreen, m_contextMenu.get());
This is the one place where we should not keep both items, right? Because this is defining what we actually see in the menu. For the Mac platform I assume we now want the toggle menu item, not the enter one.
Otherwise, this patch looks like a step in the right direction.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list