[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 7 16:55:55 PDT 2013


--- Comment #44 from Ruth Fong <ruthiecftg at gmail.com>  2013-06-07 16:54:28 PST ---
(From update of attachment 204066)
View in context: https://bugs.webkit.org/attachment.cgi?id=204066&action=review

>>>> Source/WebKit2/Shared/API/c/WKContextMenuItemTypes.h:113
>>>> +#if PLATFORM(MAC)
>>> I don't think we can add things in the middle of an API enum.
>> Wouldn't "Enter" and "Toggle" effectively be the same tag? (since only one will ever be enumerated, they'd share the same enum value?)
> You're right, ignore me.

Are you sure? Alex just persuaded me that you're right. I was going to eliminate the preprocessing conditions and just add kWKContextMenuItemTagToggleVideoFullscreen at the end of the list.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list