[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117220





--- Comment #41 from Tim Horton <thorton at apple.com>  2013-06-07 15:05:12 PST ---
(From update of attachment 204066)
View in context: https://bugs.webkit.org/attachment.cgi?id=204066&action=review

> Source/WebCore/ChangeLog:8
> +        For mac ports only, this patch allows the fullscreen 

Mac.

> Source/WebCore/html/HTMLMediaElement.cpp:4365
> +#if PLATFORM(MAC)

Wonder if you want an #if ENABLE(TOGGLE_FULLSCREEN) or something (ugh, that seems terrible too, though). Something that other ports can turn on as they change their API instead of adding themselves to this list of (currently one) platform(s).

> Source/WebKit2/Shared/API/c/WKContextMenuItemTypes.h:113
> +#if PLATFORM(MAC)

I don't think we can add things in the middle of an API enum.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.