[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 7 09:24:06 PDT 2013


--- Comment #36 from Ruth Fong <ruthiecftg at gmail.com>  2013-06-07 09:22:39 PST ---
(From update of attachment 203989)
View in context: https://bugs.webkit.org/attachment.cgi?id=203989&action=review

>> Source/WebKit2/Shared/API/c/WKSharedAPICast.h:472
>> +        return kWKContextMenuItemTagToggleVideoFullscreen;
> I don’t understand why we are removing the enter fullscreen menu item while adding the toggle fullscreen one. Who suggested the removal? What’s the rationale?

The patch changes fullscreen so that it works like the play/pause context menu item, i.e. when the video is paused, the "Play" item appears and vice versa. 

Previously, after entering fullscreen from the context menu, if you right-clicked the video to show the context menu while in fullscreen, you'd still see the "Enter Fullscreen" item, which when clicked in fullscreen, would do nothing.

The change from "Enter" to "Toggle" was meant to reflect that change in how the fullscreen context menu item would work.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list