[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117220





--- Comment #32 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-06-07 00:37:05 PST ---
(In reply to comment #31)
> (From update of attachment 203989 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203989&action=review
> 
> >> Source/WebKit/gtk/webkit/webkitglobals.h:140
> >> +    WEBKIT_CONTEXT_MENU_ACTION_TOGGLE_VIDEO_FULLSCREEN,
> > 
> > Isn't it possible to do the same than in wk2, instead of renaming? Otherwise we need to deprecate the ENTER one and add TOGGLE at the end.
> 
> I think the tag should be renamed in order to reflect the behavior appropriately; what if we introduced TOGGLE without deleting ENTER for now and file a bug for ENTER to be removed once gtk is stable and transitions to TOGGLE?

Yes, that's the other alternative, marking ENTER as deprecated and add TOGGLE at the end as a new symbol. Why is not consistent with WebKit2 API then? This patch introduces EXIT instead of TOGGLE. I would like to discuss this API with the other GTK+ reviewers (patches adding new GTK+ API must be approved by at least 2 GTK+ reviewers), and then I can update the patch with the appropriate GTK+ changes to make it easier.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.