[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117220


Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203980|review?                     |review+
               Flag|                            |




--- Comment #24 from Jer Noble <jer.noble at apple.com>  2013-06-06 17:49:16 PST ---
(From update of attachment 203980)
View in context: https://bugs.webkit.org/attachment.cgi?id=203980&action=review

> Source/WebCore/rendering/HitTestResult.cpp:421
> +    HTMLMediaElement* mediaElt = mediaElement();
> +    if (mediaElt && mediaElt->hasTagName(HTMLNames::videoTag)) {
> +        HTMLVideoElement* videoElt = static_cast<HTMLVideoElement*>(mediaElt);
> +        if (mediaElt->supportsFullscreen()) {
> +            UserGestureIndicator indicator(DefinitelyProcessingNewUserGesture);
> +            videoElt->toggleFullscreenState();
> +        }

Re-picking Geoff's nit: "mediaElt" => "mediaElement", "videoElt" => "videoElement", and solve the name collision by calling "this->mediaElement()"

Apart from that, r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.