[Webkit-unassigned] [Bug 93977] Implement testRunner.numberOfPendingGeolocationPermissionRequests()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93977


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203964|review+                     |review-
               Flag|                            |




--- Comment #3 from Benjamin Poulain <benjamin at webkit.org>  2013-06-06 13:59:36 PST ---
(From update of attachment 203964)
View in context: https://bugs.webkit.org/attachment.cgi?id=203964&action=review

This is wrong.

I think you missed what this test does.

On reload, WebKit should call GeolocationClient::cancelPermissionRequest() which should in turn cancel the permissionRequest on the UIProcess side. This part is not wired to anything which is why that does not work.
You are just breaking the test to make it pass.

> LayoutTests/ChangeLog:4
> +
> +        The testsRunner should request for Geolocation Permissions.
> +        Unskip test.

The description goes under the title. See the other changelogs.

> LayoutTests/fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js:15
> +    if (!isReload) {
> +      testRunner.setGeolocationPermission(true);
> +    }

Wrong indent.

You are breaking the test by doing this. Why do you do that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.