[Webkit-unassigned] [Bug 116534] [GStreamer] Adjust internal size on http source element when receiving data if necessary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116534


Andre Moreira Magalhaes <andrunko at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203946|0                           |1
        is obsolete|                            |
 Attachment #203946|review?, commit-queue?      |
               Flag|                            |
 Attachment #203947|                            |review?, commit-queue?
               Flag|                            |




--- Comment #9 from Andre Moreira Magalhaes <andrunko at gmail.com>  2013-06-06 10:16:07 PST ---
Created an attachment (id=203947)
 --> (https://bugs.webkit.org/attachment.cgi?id=203947&action=review)
Adjust internal size when receiving data if needed 

(In reply to comment #8)
> > > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1020
> > > > +    if (priv->size != 0 && priv->offset > priv->size) {
> > > 
> > > This is confusing offset and size are both unsigned so if offset == 0 it will never be > size. This could probably just be 
> > > 
> > > if (priv->offset > priv->size)
> > > 
> > But IIRC, if priv->size == 0 (set in didReceiveResponse) we don't want/need to update the internal size as didReceiveResponse will disable seek, etc on the gst appsrc. No change here
> 
> You are right, I read the comparison wrongly. But still, you should do:
> 
> if (priv->size && priv->offset > priv->size)
> 
> or 
> 
> if (priv->size > 0 && priv->offset > priv->size)
> 
> to make the style bot happy.
hehe, done :).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.