[Webkit-unassigned] [Bug 116534] [GStreamer] Adjust internal size on http source element when receiving data if necessary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116534


Andre Moreira Magalhaes <andrunko at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202424|0                           |1
        is obsolete|                            |
 Attachment #203946|                            |review?, commit-queue?
               Flag|                            |




--- Comment #6 from Andre Moreira Magalhaes <andrunko at gmail.com>  2013-06-06 09:58:43 PST ---
Created an attachment (id=203946)
 --> (https://bugs.webkit.org/attachment.cgi?id=203946&action=review)
Adjust internal size when receiving data if needed 

(In reply to comment #5)
> (From update of attachment 202424 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202424&action=review
> 
> Please, fix coding style issues before landing.
> 
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1019
> > +    // priv->size == 0 if received length on didReceiveResponse < 0
> 
> Nit: According to the coding style comments should finish with a period.
> 
Done

> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1020
> > +    if (priv->size != 0 && priv->offset > priv->size) {
> 
> This is confusing offset and size are both unsigned so if offset == 0 it will never be > size. This could probably just be 
> 
> if (priv->offset > priv->size)
> 
But IIRC, if priv->size == 0 (set in didReceiveResponse) we don't want/need to update the internal size as didReceiveResponse will disable seek, etc on the gst appsrc. No change here

> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1021
> > +        GST_DEBUG_OBJECT(m_src, "Updating internal size from %ld to %ld", priv->size, priv->offset);
> 
> size and offset are guint64, you should probably use G_GUINT64_FORMAT instead of %ld.
Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.