[Webkit-unassigned] [Bug 117199] [CSSRegions] Improve getRegionsByContent by testing in flow thread coordinates instead of view coordinates

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117199


Alexandru Chiculita <achicu at adobe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203702|review?                     |review-
               Flag|                            |




--- Comment #2 from Alexandru Chiculita <achicu at adobe.com>  2013-06-06 09:51:12 PST ---
(From update of attachment 203702)
View in context: https://bugs.webkit.org/attachment.cgi?id=203702&action=review

> Source/WebCore/rendering/RenderFlowThread.cpp:818
> +    LayoutRect boundingBox;

Why not just use localToContainerQuad instead (now that it can also return coordinates in the flowthread space)?

> Source/WebCore/rendering/RenderFlowThread.cpp:824
> +        ASSERT(false);

nit: this could be ASSERT_NOT_REACHED.

Why only renderInlines and text? Looks like the caller could send any node in here.

> Source/WebKit2/Shared/WebPreferencesStore.h:98
> +    macro(RegionBasedColumnsEnabled, regionBasedColumnsEnabled, Bool, bool, true) \

I don't see any comments in the changelog about this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.