[Webkit-unassigned] [Bug 117288] ResourceLoader::resourceData() should not return a PassRefPtr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 6 09:23:46 PDT 2013


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #203924|review?                     |review+
               Flag|                            |

--- Comment #2 from Darin Adler <darin at apple.com>  2013-06-06 09:22:20 PST ---
(From update of attachment 203924)
View in context: https://bugs.webkit.org/attachment.cgi?id=203924&action=review

> Source/WebCore/ChangeLog:10
> +        Change ResourceLoader::resourceData() to return a raw pointer
> +        instead of a PassRefPtr since we don't want to transfer the
> +        ownership of the resource data. Also pass a raw pointer to

Definitely a good change.

> Source/WebCore/ChangeLog:14
> +        CachedResource::data() so that the cached resource can decide
> +        whether to take a reference of the data or not, for example,
> +        CachedRawResource only takes a reference when buffering policy is
> +        BufferData.

Not sure this change is as good, but it’s OK.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list