[Webkit-unassigned] [Bug 117256] [curl] Add implementation for HTTP PUT method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117256


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203852|review?                     |review-
               Flag|                            |




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org>  2013-06-05 14:23:54 PST ---
(From update of attachment 203852)
View in context: https://bugs.webkit.org/attachment.cgi?id=203852&action=review

Looks very good.  I had a couple of things I'd like you to cleanup before we land.  Thanks!

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:484
> + */

We don't usually add header comments like these. We prefer to have the function/method name describe what the method does.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:556
> + */

Comment is unecessary

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:574
> + */

Comment is unecessary

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:586
> +    Vector<FormDataElement> elements = job->firstRequest().httpBody()->elements();

I don't think this Vector is needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.