[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 5 07:56:33 PDT 2013


--- Comment #8 from Eric Carlson <eric.carlson at apple.com>  2013-06-05 07:55:07 PST ---
(From update of attachment 203747)
View in context: https://bugs.webkit.org/attachment.cgi?id=203747&action=review

> Source/WebCore/rendering/HitTestResult.cpp:405
> +    HTMLMediaElement* mediaElt = mediaElement();

Nit: "mediaElt" seems odd and letters are cheap, I would spell out the variable name.

> Source/WebCore/rendering/HitTestResult.cpp:415
> +    HTMLMediaElement* mediaElt(mediaElement());


We usually use "=" for an assignment like this.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list