[Webkit-unassigned] [Bug 117212] New: [Windows] Revise Windows code in NRWT to properly distinguish between "win32" and "cygwin" behavior

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 4 15:12:01 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117212

           Summary: [Windows] Revise Windows code in NRWT to properly
                    distinguish between "win32" and "cygwin" behavior
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bfulgham at webkit.org


Dirk Pranke pointed out that changes I made under Bug 117098 improperly treated the "win32" and "cygwin" variants of Windows builds as the same thing.  Unfortunately, Windows does not provide a 'ps' tool, and so cannot be handled the same way as our Cygwin infrastructure.

This patch makes the following corrections:

1. It returns to the original "win32" behavior of returning an empty list when attempting to find running PIDs.
2. Revise crashlog object to accept a "results directory" argument, rather than requiring the user to pass a port object when attempting to retrieve crash logs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list