[Webkit-unassigned] [Bug 117177] New: change MediaControlToggleClosedCaptionsButtonElement type to checkbox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117177

           Summary: change MediaControlToggleClosedCaptionsButtonElement
                    type to checkbox
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: danilo.cesar at collabora.co.uk


Created an attachment (id=203646)
 --> (https://bugs.webkit.org/attachment.cgi?id=203646&action=review)
patch

it's a draft patch to change the type of the MediaControlToggleClosedCaptionsButtonElement from "button" to "checkbox"

For what I could see, all ports except Mac treats the MediaControlToggleClosedCaptionsButtonElement as a toggle button to show/hide captions/subtitles from html videos.
They even use setChecked(true/false) as a "state" for this button.
However the checked state is useless on a mediaControl[PORT].css point of view because the css selector ":checked" is not valid for <input type=button>

My propose here is to change the type of that button to checkbox and change the defaultEventHandler to get the changeEvent. 
That way, ports will be able to use that information by css and current implementations won't be hurt.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.