[Webkit-unassigned] [Bug 117166] New: TypingCommand::deleteKeyPressed doesn't register EditComposition to undo manager in some cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117166

           Summary: TypingCommand::deleteKeyPressed doesn't register
                    EditComposition to undo manager in some cases
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: darin at apple.com, enrica at apple.com
        Depends on: 117165


While working on the bug 117165, I've converted the following comment in CompositeEditCommand::apply to an assertion:

    // Only need to call appliedEditing for top-level commands,
    // and TypingCommands do it on their own (see TypingCommand::typingAddedToOpenCommand).
    if (!isTypingCommand())
        frame->editor().appliedEditing(this);

and found a nasty bug where TypingCommand wasn't registering itself to the undo manager in some cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.