[Webkit-unassigned] [Bug 115647] [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 3 13:31:11 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115647


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203613|review?                     |review-
               Flag|                            |




--- Comment #30 from Martin Robinson <mrobinson at webkit.org>  2013-06-03 13:29:42 PST ---
(From update of attachment 203613)
View in context: https://bugs.webkit.org/attachment.cgi?id=203613&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:820
> +        atk_attribute_set_free(textAttributes.get());

I think it's a mistake to use a GOwnPtr and to manually free the same thing. Either make GOwnPtr specialization for AtkTextAttributes (if one doesn't exist already) or free it manually.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list